Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visionOS to @available annotations where we use them #414

Open
simonjbeaumont opened this issue Dec 1, 2023 · 0 comments
Open

Add visionOS to @available annotations where we use them #414

simonjbeaumont opened this issue Dec 1, 2023 · 0 comments
Labels
area/transport Affects: Client or server transport library. kind/enhacement Improvements to existing feature.
Milestone

Comments

@simonjbeaumont
Copy link
Contributor

While the current Linux toolchains are happy to have visionOS in the platforms: in Package.swift, it seems they don't it being mentioned in the list of platforms in an @available annotation yet.

We tried to add it to the URLSession transport in apple/swift-openapi-urlsession#41. This succeeds in the latest Xcode release (15.0.1), but it fails in our Linux CI.

/code/Sources/OpenAPIURLSession/BufferedStream/BufferedStream.swift:1010:53: error: unrecognized platform name 'visionOS'
@available(macOS 10.15, iOS 13, tvOS 13, watchOS 6, visionOS 1, *)

Note, this is only a warning but, because we compile with -warnings-as-errors, it gets promoted by the CI, and there's no current way to selectively opt-out of errors on a per-error or per-file basis.

We'll backlog this issue to post-1.0 and pick it up when we have it available for use in the Linux toolchain.

@simonjbeaumont simonjbeaumont added this to the Post-1.0 milestone Dec 1, 2023
@czechboy0 czechboy0 added area/transport Affects: Client or server transport library. kind/enhacement Improvements to existing feature. labels Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/transport Affects: Client or server transport library. kind/enhacement Improvements to existing feature.
Projects
None yet
Development

No branches or pull requests

2 participants