Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom verify callback to servers. #226

Merged
merged 1 commit into from
Jun 16, 2020

Commits on Jun 16, 2020

  1. Add support for custom verify callback to servers.

    Motivation:
    
    In apple#171 when we worked on providing access to the better verification
    callback, we managed to entirely miss that we had not provided that
    access to servers. This meant they were stuck only with the
    substantially-less-useful old-school callback, instead of the much
    better new-school one.
    
    While we're here, as we had to add multiple new initializers to
    NIOSSLServerHandler, I took the opportunity to also resolve the server
    handler portion of apple#147. The issue itself is still open because the
    client handlers still have throwing inits, but all "preferred"
    initializers on NIOSSLServerHandler no longer throw.
    
    Modifications:
    
    - Deprecated NIOSSLServerHandler.init(context:verificationCallback:)
    - Implemented two new initializers on NIOSSLServerHandler.
    - Added tests to verify that the NIOSSLServerHandler verification
      callback is actually called.
    - Removed all now-unnecessary try keywords.
    
    Result:
    
    Users will be able to provide custom verification callbacks that work
    much better than they currently can when on the server, and the server
    is now back into feature parity with the client.
    Lukasa committed Jun 16, 2020
    Configuration menu
    Copy the full SHA
    ca40773 View commit details
    Browse the repository at this point in the history