Add support for custom verify callback to servers. #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weissi
reviewed
Jun 16, 2020
| @@ -34,7 +34,7 @@ final class BenchManyWrites: Benchmark { | |||
| } | |||
|
|
|||
| func setUp() throws { | |||
| let serverHandler = try NIOSSLServerHandler(context: self.serverContext) | |||
| let serverHandler = NIOSSLServerHandler(context: self.serverContext) | |||
weissi
approved these changes
Jun 16, 2020
Motivation: In apple#171 when we worked on providing access to the better verification callback, we managed to entirely miss that we had not provided that access to servers. This meant they were stuck only with the substantially-less-useful old-school callback, instead of the much better new-school one. While we're here, as we had to add multiple new initializers to NIOSSLServerHandler, I took the opportunity to also resolve the server handler portion of apple#147. The issue itself is still open because the client handlers still have throwing inits, but all "preferred" initializers on NIOSSLServerHandler no longer throw. Modifications: - Deprecated NIOSSLServerHandler.init(context:verificationCallback:) - Implemented two new initializers on NIOSSLServerHandler. - Added tests to verify that the NIOSSLServerHandler verification callback is actually called. - Removed all now-unnecessary try keywords. Result: Users will be able to provide custom verification callbacks that work much better than they currently can when on the server, and the server is now back into feature parity with the client.
Lukasa
force-pushed
the
cb-set-custom-verify-server
branch
from
54570a1
to
ca40773
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
In #171 when we worked on providing access to the better verification
callback, we managed to entirely miss that we had not provided that
access to servers. This meant they were stuck only with the
substantially-less-useful old-school callback, instead of the much
better new-school one.
While we're here, as we had to add multiple new initializers to
NIOSSLServerHandler, I took the opportunity to also resolve the server
handler portion of #147. The issue itself is still open because the
client handlers still have throwing inits, but all "preferred"
initializers on NIOSSLServerHandler no longer throw.
Modifications:
callback is actually called.
Result:
Users will be able to provide custom verification callbacks that work
much better than they currently can when on the server, and the server
is now back into feature parity with the client.