-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New form component for skill suggestions #319
Comments
|
@maxceem I checked the API, and it seems we don't have the ability to update the skills without admin privileges. I think for now we can just store the custom skills typed by the user only in our connect database as our regular question in |
@vikasrohit so we would store skills names like |
I think we can keep |
@maxceem do you think when ca we get these changes (fetching the skills from the api)? |
@vikasrohit yes we can do that. The only thing I'm not sure if we should move this component to the react-components. The logic feels quite specific to Connect app. It feels that react-components is good for basic components which would be reused multiple times like |
I think it makes sense to have this component in react-components (and later on we might have to move it to react-utils repo), because I think we can use this component in community app as well to let users select the skills with some frequent skills listed on the top and in fact we can configure out component in way that it won't show frequent skills if they are not specified in its props so essentially it would look like exactly same we have on the profile page in community app right now. In summary, I think it is a good candidate to move to the react-components, however, it is not urgent to move it there. We can do that later, just log a ticket for this for future reference. |
Got it @vikasrohit. The last thing. Currently, we filter skills based on the selected deliverables. We have the next values for deliverables:
While in the data returned by API we have the next categories:
So there are two questions:
|
I think we need to keep the mapping between the deliverables and skills categories, in the template itself and pass the final category that is determined from that mapping to Skills components in react-components and if no category is determined from the mapping or there is no mapping specified, we won't pass any category to the Skills component which would in turn not filter skills based on any category and would list all skills. This way we can configure the component from the template in a way that we don't filter the skills by category at all. |
If no mapping specified - we show the all the items - it's clear.
I have some concerns regarding this. If we didn't choose any deliverables then no categories would be determined. Should we show all the skills in such case? See how it looks at the moment: |
Yep, I think we should be good with that. We would hide (by moving it to next subsection) the skill picker until user selects the deliverables in the first step. |
(Users can select multiple answers)
Answers:
Primary Answers: These answer options should be displayed immediately as checkboxes. It is optional for the user to complete this question.
Display this Text above the answer options: Most Commonly Requested Skills:
Secondary Answer Option:
Underneath the commonly requested skills, display a responsive field for the user to type in additional skills.
The text was updated successfully, but these errors were encountered: