Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make forum creation optional #551

Open
ajefts opened this issue Dec 18, 2020 · 10 comments
Open

Make forum creation optional #551

ajefts opened this issue Dec 18, 2020 · 10 comments

Comments

@ajefts
Copy link
Contributor

ajefts commented Dec 18, 2020

During challenge creation, we'd like to allow a flag to be passed in that determines whether or not the challenge forum should be created during the challenge creation process.

  1. By default, create a forum.
  2. If the global property to create a forum is turned off, don't create any forums.
  3. If the POST request contains ?skipForum=true, don't create the forum.

I believe this is the code we'd need to work with: https://github.com/appirio-tech/direct-app/blob/dev/services/contest_service_facade/src/java/main/com/topcoder/service/facade/contest/ejb/ContestServiceFacadeBean.java#L3663

@ajefts
Copy link
Contributor Author

ajefts commented Dec 18, 2020

@deedee @Schpotsky @skyhit Would you have any interest in coding this change?

@ajefts
Copy link
Contributor Author

ajefts commented Dec 18, 2020

cc: @rootelement

@mtwomey
Copy link
Contributor

mtwomey commented Dec 18, 2020

Notes:

  1. In this below: This receives the call from Work Manager, it needs to also receive an option to not create the Jive forums.

https://github.com/appirio-tech/ap-challenge-microservice/blob/25ee7903ee710079d5fb1f6371037b30971ce151/src/main/java/com/appirio/service/challenge/resources/ChallengeResource.java#L206

  1. In this below: When it calls direct it needs to somehow pass in the option to not create the Jive forums:

https://github.com/appirio-tech/ap-challenge-microservice/blob/25ee7903ee710079d5fb1f6371037b30971ce151/src/main/java/com/appirio/service/challenge/directmanager/ContestDirectManager.java#L846

  1. In direct, recognize the option to not create the Jive forums and then don't create them:

public SoftwareCompetition createSoftwareContest(TCSubject tcSubject, SoftwareCompetition contest,

  1. Add logging - TBD

@rootelement
Copy link
Contributor

@kylewu if you're bored and want to take a look here too :)

@Jaouad-Jaghrir
Copy link
Collaborator

@ajefts
I have some other tasks to do now.
I may look into it later when I have some time if still not implemented

@kylewu
Copy link
Collaborator

kylewu commented Dec 21, 2020

@ajefts how could I test this locally? I remember there is a repo with docker setup

@kylewu
Copy link
Collaborator

kylewu commented Dec 21, 2020

ajefts added a commit that referenced this issue Dec 21, 2020
#551 allow skipForum in ContestServiceFacadeBean.createSoftwareContest
@kylewu
Copy link
Collaborator

kylewu commented Dec 21, 2020

@ajefts @rootelement I believe there was an issue with my previous PR: the interface was not updated

@rootelement ap-challenge-microservice needs to upgrade dependency contest_service_facade, otherwise it won't compile

@rootelement
Copy link
Contributor

@kylewu we had merged this to dev, but had to pull it back out. can you make an updated PR?

@kylewu
Copy link
Collaborator

kylewu commented Dec 22, 2020

@rootelement #554 here it is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants