Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$75] [Account App] sync businessPhone validation with member api #3494

Closed
maxceem opened this issue Jan 20, 2020 · 21 comments
Closed

[$75] [Account App] sync businessPhone validation with member api #3494

maxceem opened this issue Jan 20, 2020 · 21 comments

Comments

@maxceem
Copy link
Collaborator

maxceem commented Jan 20, 2020

The current issue is used to track a task in another repository during the Bug Bash challenge.

See task details appirio-tech/accounts-app#333

All the comments to assign, unassign and ready for review should be done here in the current issue in Connect App.

@maxceem maxceem changed the title [Account App] sync businessPhone validation with member api [$75] [Account App] sync businessPhone validation with member api Jan 21, 2020
@maxceem maxceem added Open for Pickup CF Issue for Community Fixes in the current Bug Bash and removed cf-pipeline labels Jan 21, 2020
@mhikeo
Copy link
Contributor

mhikeo commented Jan 21, 2020

@bug-bash-helper assign

@bug-bash-helper
Copy link

@mhikeo you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

@maxceem
Copy link
Collaborator Author

maxceem commented Jan 22, 2020

As no PR has been provided for 12 hours this issue has been unassigned and now is open for pickup.

@yoution
Copy link
Collaborator

yoution commented Jan 22, 2020

@bug-bash-helper assign

@bug-bash-helper
Copy link

@yoution you are now assigned to this issue and have 12 hours to complete it.

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

@yoution
Copy link
Collaborator

yoution commented Jan 22, 2020

@bug-bash-helper appirio-tech/react-components#346 is ready for review

@bug-bash-helper
Copy link

Hi @yoution.

assign

To assign yourself to the issue make a comment:

@bug-bash-helper assign me

unassign

To unassign yourself from the issue make a comment:

@bug-bash-helper unassign me

ready for review

As soon as you are done, please, make a comment like below, including the link to the pull request:

@bug-bash-helper <link to PR> is ready for review

@yoution
Copy link
Collaborator

yoution commented Jan 22, 2020

@bug-bash-helper appirio-tech/react-components#346 ready for review

@bug-bash-helper
Copy link

@yoution this issue is marked as Ready for Review.

Now you may pick up another issue which is open for pickup if you like to.

@yoution
Copy link
Collaborator

yoution commented Jan 22, 2020

@maxceem please review these two repos, #3507
appirio-tech/react-components#346

@maxceem maxceem added Feedback The issue hasn't been fixed completely and some feedback has been provided. and removed Ready for Review labels Jan 23, 2020
@maxceem
Copy link
Collaborator Author

maxceem commented Jan 23, 2020

@yoution works mostly good. Though implementation doesn't reuse formsy features, that should make the code simpler, as PhoneInput component is already implemented as formsy component.
Please, have a look at the reviews in Connect App #3507 (review) and in React Components repo appirio-tech/react-components#346 (review)

yoution added a commit to yoution/connect-app that referenced this issue Jan 23, 2020
@yoution
Copy link
Collaborator

yoution commented Jan 23, 2020

@maxceem appirio-tech/react-components#347
appirio-tech/react-components#347

i pushed again for country code validate, but the issue in registerscreen page, the country code can not show, it maybe not my problem, the code I changed may not cause the problem, please check again

@maxceem maxceem added Feedback The issue hasn't been fixed completely and some feedback has been provided. and removed Ready for Review labels Jan 24, 2020
@maxceem
Copy link
Collaborator Author

maxceem commented Jan 24, 2020

@yoution I've checked it out, please, have a look at review #3507 (comment).

yoution added a commit to yoution/connect-app that referenced this issue Jan 24, 2020
@maxceem maxceem added ACCEPTED and removed Feedback The issue hasn't been fixed completely and some feedback has been provided. labels Jan 25, 2020
@maxceem maxceem added this to the 2.5.1 milestone Jan 27, 2020
@nithyaasworld
Copy link
Collaborator

@maxceem I entered the below info when registering. But when I checked in My-Profile after completing the registration, the info I entered are not seen. Could you check please?

image
image

@yoution
Copy link
Collaborator

yoution commented Jan 29, 2020

@maxceem appirio-tech/react-components#349 please review

@maxceem
Copy link
Collaborator Author

maxceem commented Jan 29, 2020

@nithyaasworld this has been fixed and ready for testing on DEV.

@drasticdpk
Copy link
Collaborator

Still got the same issue in Production, the registered information is not being reflected in Profile page.
image.

@RishiRajSahu
Copy link
Contributor

@drasticdpk could you please test again should be working fine now ?

@vikasrohit
Copy link

Closing. Please feel free to create new issue for any new findings or reopen if the issue still persists.

@drasticdpk
Copy link
Collaborator

Verified on prod env, it is working as expected.
image

@maxceem maxceem removed the CF Issue for Community Fixes in the current Bug Bash label Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants