-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a Multiple Choice Questionnaire #2
Open
ronaldngounou
wants to merge
31
commits into
appbrewery:master
Choose a base branch
from
ronaldngounou:ChoicesFeature
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Pull Request Alexander
…oard. The old version was starting the app from the main story board and this version is starting the app from the view Controller
…ersion, the code is running but it stays on a black screen. The error says: "Failed to instantiate the default view controller for UIMainStoryboardFile 'Main' - perhaps the designated entry point is not set?" To solve this issue, I tried added the 'Main' value for the StoryBoard property in the Info.plist.
Modified the usage of force unwrap. The old version was using force unwrapping which is a sign of bad design. The new version handles force unwrapping by raising an error in case of failure.
Mutating in a structure is often a sign of bad design. The old version was using mutatings inside the struct. The current version uses a final class QuizBrain with public functions inside the QuizBrain model.
…ping In this version, I am stucked with 2 errors stating "unexpectedly found nil while implicitly unwrapping an optional value" I tried to resolve it by following the same logic but still not working.
…ping In this version, I am stucked with 2 errors stating "unexpectedly found nil while implicitly unwrapping an optional value" I tried to resolve it by following the same logic but still not working.
Unexpectedly found nil while implicitly unwrapping an Optional value
Conflicts: Quizzler-iOS13/SceneDelegate.swift
initialize new branch
- TO DO: Update labels and their connections to the view - 3 buttons connected to the same function.
start QuizViewController
…zzler-iOS13 into ChoicesFeature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope to accomplish 3 tasks in this pull requests: