New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESClient method spec #1

Open

siddharthlatest opened this issue Nov 4, 2018 · 1 comment

Milestone

Member

siddharthlatest commented Nov 4, 2018

Follow a signature similar to the JS client we have here - https://docs.appbase.io/javascript/api-reference.html#appbase.

https://github.com/harsh-2711/SwiftElasticSearch/blob/bf20eec8bec88b48edbe16929af50684d14c90d9/SwiftElasticSearch/SwiftElasticSearch/SwiftElasticSearch.swift#L119

username, password are redundant parameters for credentials.
We shouldn't ask for sslconfig from the user.

siddharthlatest added this to the 0.0.1 milestone

Member Author

siddharthlatest commented Nov 11, 2018

url should also take the scheme from the user. Example value can be: "https://elasticsearch:9200"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment