If an example preset script fails some portions of that example are still installed #209
Labels
bug
Something isn't working
passed-dev-qa
Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main
refactor
Milestone
Describe the bug
Version conflicts checks for example presets happen right before the script that installs the example is ran but after framework for that example is installed, this results in a potion of the example being installed but not the whole thing.
Screenshots
Steps to reproduce
set
starter.ini` to laravel version 9.*starter.ini
to PHP version 8.0The Vue example will not be installed however the Vue framework will be installed and some portions of
starter.ini
will be bypassed as if the Vue example preset was fully installed. See the summary ine the terminal output for more details.Expected behavior
If an example preset is not installed and then nothing in
starter.ini
should be bypassed. At least make this less likley to happen.Additional information
This can be refactored in
init-optional-scaffolding.sh
by making the version checks before or during the directive are changes (see the big case statement in that file) rather than at the end right before the install script for that example is sourced/executed.The text was updated successfully, but these errors were encountered: