Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If an example preset script fails some portions of that example are still installed #209

Open
apolopena opened this issue Mar 5, 2022 · 0 comments
Assignees
Labels
bug Something isn't working passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main refactor

Comments

@apolopena
Copy link
Owner

apolopena commented Mar 5, 2022

Describe the bug

Version conflicts checks for example presets happen right before the script that installs the example is ran but after framework for that example is installed, this results in a potion of the example being installed but not the whole thing.

Screenshots

Steps to reproduce

  1. set starter.ini` to laravel version 9.*
  2. Set starter.ini to PHP version 8.0
  3. Run the workspace with #EXAMPLE=10 to activate the vue example preset

The Vue example will not be installed however the Vue framework will be installed and some portions of starter.ini will be bypassed as if the Vue example preset was fully installed. See the summary ine the terminal output for more details.

Expected behavior

If an example preset is not installed and then nothing in starter.ini should be bypassed. At least make this less likley to happen.

Additional information

This can be refactored in init-optional-scaffolding.sh by making the version checks before or during the directive are changes (see the big case statement in that file) rather than at the end right before the install script for that example is sourced/executed.

@apolopena apolopena added the bug Something isn't working label Mar 5, 2022
@apolopena apolopena self-assigned this Mar 5, 2022
@apolopena apolopena added this to the v1.6 release 🚀 milestone Mar 5, 2022
@apolopena apolopena changed the title If an example preset script fails some portions of the exmaple are still installed If an example preset script fails some portions of that example are still installed Mar 5, 2022
@apolopena apolopena added refactor in-development Bug or feature is currently being worked on labels Mar 5, 2022
apolopena added a commit that referenced this issue Mar 5, 2022
apolopena added a commit that referenced this issue Mar 5, 2022
@apolopena apolopena added in-dev-qa passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main and removed in-development Bug or feature is currently being worked on in-dev-qa labels Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main refactor
Projects
None yet
Development

No branches or pull requests

1 participant