Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 9 Support #206

Open
bradley-varol opened this issue Mar 4, 2022 · 7 comments
Open

Laravel 9 Support #206

bradley-varol opened this issue Mar 4, 2022 · 7 comments
Assignees
Labels
enhancement New feature or request passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main

Comments

@bradley-varol
Copy link

Laravel 9 is now released - when can we expect to see Laravel 9 support here?

@bradley-varol bradley-varol added the enhancement New feature or request label Mar 4, 2022
@apolopena apolopena self-assigned this Mar 4, 2022
@apolopena apolopena added this to the v1.6 release 🚀 milestone Mar 4, 2022
@apolopena
Copy link
Owner

@bradley-varol Thank you for bringing this to my attention.

I will scope the effort today and reply back here with an ETA.
Barring any craziness found in testing I don't see why this can't make it into the next release v1.6 🚀

@bradley-varol
Copy link
Author

Thank you @apolopena . In hindsight my PR description was a little demanding 😁

Looking forward to an ETA and getting started with this repo!

@apolopena apolopena added the in-development Bug or feature is currently being worked on label Mar 5, 2022
apolopena added a commit that referenced this issue Mar 5, 2022
apolopena added a commit that referenced this issue Mar 5, 2022
@apolopena
Copy link
Owner

@bradley-varol No worries. Welcome to the repo!

@apolopena
Copy link
Owner

Looking good so far
image

@apolopena
Copy link
Owner

And the workspace builds 😄 🚀
image

apolopena added a commit that referenced this issue Mar 5, 2022
apolopena added a commit that referenced this issue Mar 5, 2022
@apolopena
Copy link
Owner

apolopena commented Mar 5, 2022

All presets work except The Vue preset that uses Material Dashboard.
I raised an issue with them.
I have the output of material dashboard install stifled so I don't know what the exact error is ATM. I assume it is an issue in material-dashboard since their latest release was in September 2021 and is labeled "Update to Laravel 8.x"

TODOS:

  • Bypass this preset for now when laravel is >= 9.*
  • Make note of this bypass in the readme.

@apolopena apolopena added third party bug This bug is a result of an issue in a third party library. in-dev-qa passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main and removed third party bug This bug is a result of an issue in a third party library. in-development Bug or feature is currently being worked on in-dev-qa labels Mar 5, 2022
@apolopena
Copy link
Owner

Everything looks good. This will be released in v1.6 which is ahead of schedule.

Meanwhile you can test it or use it from the development-206 branch which is stable at the moment:
https://github.com/apolopena/gitpod-laravel-starter/tree/development-206

Note:
If you actually build a project from this branch you should update it with the latest release when it comes out.
Currently, updating gitpod-laravel-starter is a manual effort until #187 is completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request passed-dev-qa Optional state. Use this when QAing other peoples fixes in another branch.ready to be merged to main
Projects
None yet
Development

No branches or pull requests

2 participants