Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transmit and Receive Frame IDs #33

Open
CaptKrasno opened this issue Jan 17, 2023 · 4 comments
Open

Transmit and Receive Frame IDs #33

CaptKrasno opened this issue Jan 17, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@CaptKrasno
Copy link
Collaborator

On many (technically speaking all) multibeams have two different reference frame for transmission and for receive. This probably isn't a big deal for small, factory assembled, units like the Norbit or Kongberg M3. However, larger units have a hull mounted transmit and receive units that can be arbitrarily placed.

As I move into formal multibeam projection geometry I would like to formalize how we treat these associated frames.

I suggest we add 2 new fields to ping_info.

  • tx_frame_id
  • rx_frame_id

Note: for backwards compatibility and for for small, factory assembled, units these may be the same.

For the header frame_id, I propose simply default to the tx_frame_id (as this is the timestamp associated with the time in the header). We can consider this the "master" frame of the unit for sensor-relative projections. This will make for an easy bag conversion rule too to update old messages.

@CaptKrasno
Copy link
Collaborator Author

@valschmidt and @rolker I would appreciate any input you have on this

@CaptKrasno CaptKrasno added the enhancement New feature or request label Jan 18, 2023
@lauralindzey
Copy link
Collaborator

Seems fine to me, but also, I don't work with large ship-mounted multibeams.

When you put together a pull request, I'll be happy to test the bag migration rule.

@CaptKrasno
Copy link
Collaborator Author

Ok. I will make a pull request shortly

@lauralindzey
Copy link
Collaborator

We discussed this briefly.

@rolker suggested only adding receive frame ID, and require the header to have the transmit frame.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

3 participants