Skip to content
This repository has been archived by the owner on Dec 25, 2023. It is now read-only.

Add support for custom rules dirs #75

Merged
merged 9 commits into from
Jan 25, 2021
Merged

Add support for custom rules dirs #75

merged 9 commits into from
Jan 25, 2021

Conversation

apexskier
Copy link
Owner

@apexskier apexskier commented Jan 19, 2021

Resolves #68

@markholland

@markholland
Copy link

markholland commented Jan 19, 2021

If I set a Rules Directory in extension preferences everything works as expected but if I set the same directory in Project Settings instead then no linting appears to be happening.

I'm always using the browse button when adding a Rules Directory.

Edit: If I add an absolute path to Project Settings it works. Using browse from Project Settings as I'd expect it adds a relative path but that appears to lead to no linting. The relative project path is .eslint/rules if this helps to know.

@apexskier
Copy link
Owner Author

Very weird - this is the underlying bug for the issue you found - gkz/optionator#34

@apexskier
Copy link
Owner Author

@markholland Can you test once more? I added a workaround for the underlying issue. After digging around in the dependencies eslint uses for options parsing, I don't expect a root cause fix to come any time soon, but this should work.

@markholland
Copy link

Yes, this is now working with relative paths in Project Settings.

@apexskier apexskier merged commit 135760c into main Jan 25, 2021
@apexskier apexskier deleted the custom-rules-dirs branch January 25, 2021 18:10
@github-actions
Copy link

Included in release v1.7.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to set options.rulePaths or --rulesdir
2 participants