chore: hostNetwork supports sharding #8517
Conversation
Y-Rookie
requested review from
nayutah,
ldming,
heng4fun,
free6om and
wangyelei
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-0.9 #8517 +/- ##
===============================================
+ Coverage 64.84% 64.93% +0.08%
===============================================
Files 358 358
Lines 45523 45514 -9
===============================================
+ Hits 29521 29555 +34
+ Misses 13374 13334 -40
+ Partials 2628 2625 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
pkg/controller/component/utils.go
Outdated
| return slices.Index(strings.Split(comps, ","), compName) >= 0 | ||
|
|
||
| compsList := strings.Split(comps, ",") | ||
| return slices.Contains(compsList, synthesizedComp.Name) || slices.Contains(compsList, synthesizedComp.ShardingName) |
There was a problem hiding this comment.
Refactor the conversion (from sharding to components) to be handled by the cluster controller, rather than embedding its into components.
There was a problem hiding this comment.
Refactor the conversion (from sharding to components) to be handled by the cluster controller, rather than embedding its into components.
done
No description provided.