Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support "kbcli backuprepo delete" #92

Merged
merged 2 commits into from
Dec 7, 2023
Merged

Conversation

zjx20
Copy link
Contributor

@zjx20 zjx20 commented Dec 6, 2023

Close #79.

@github-actions github-actions bot added the size/L Denotes a PR that changes 100-499 lines. label Dec 6, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (4a81fde) 42.92% compared to head (4031216) 43.00%.
Report is 1 commits behind head on main.

❗ Current head 4031216 differs from pull request most recent head bf9c6af. Consider uploading reports for the commit bf9c6af to get more accurate results

Files Patch % Lines
pkg/cmd/backuprepo/delete.go 67.50% 9 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #92      +/-   ##
==========================================
+ Coverage   42.92%   43.00%   +0.07%     
==========================================
  Files         223      224       +1     
  Lines       28626    28683      +57     
==========================================
+ Hits        12289    12335      +46     
- Misses      14811    14819       +8     
- Partials     1526     1529       +3     
Flag Coverage Δ
unittests 43.00% <77.19%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zjx20 zjx20 merged commit de30043 into main Dec 7, 2023
5 checks passed
@zjx20 zjx20 deleted the feature/backuprepo-delete branch December 7, 2023 01:15
@github-actions github-actions bot added this to the Release 0.8.0 milestone Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement]kbcli backuprepo delete ?
3 participants