Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: immutableParameters will be show as dynamicParameters (#5945) #75

Conversation

sophon-zt
Copy link
Contributor

@sophon-zt sophon-zt requested a review from 1aal as a code owner November 28, 2023 15:41
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines. label Nov 28, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (74c1920) 43.00% compared to head (a6076c7) 42.97%.

Files Patch % Lines
pkg/cmd/cluster/config_observer.go 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #75      +/-   ##
==========================================
- Coverage   43.00%   42.97%   -0.04%     
==========================================
  Files         223      223              
  Lines       28566    28571       +5     
==========================================
- Hits        12286    12278       -8     
- Misses      14764    14775      +11     
- Partials     1516     1518       +2     
Flag Coverage Δ
unittests 42.97% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ldming ldming merged commit aea081b into main Dec 4, 2023
19 checks passed
@ldming ldming deleted the bugfix/immutableparameters-will-be-show-as-dynamicparameters-issue5945 branch December 4, 2023 01:18
@github-actions github-actions bot added this to the Release 0.8.0 milestone Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]immutableParameters will be show as dynamicParameters
5 participants