Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: addon search #44

Merged
merged 24 commits into from
Nov 25, 2023
Merged

feat: addon search #44

merged 24 commits into from
Nov 25, 2023

Conversation

1aal
Copy link
Contributor

@1aal 1aal commented Nov 15, 2023

@github-actions github-actions bot added the size/XL Denotes a PR that changes 500-999 lines. label Nov 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2023 •
edited
Loading

Codecov Report

Attention: 36 lines in your changes are missing coverage. Please review.

Comparison is base (756333e) 43.12% compared to head (8359b33) 43.17%.

Files Patch % Lines
pkg/cmd/addon/search.go 65.27% 19 Missing and 6 partials ⚠️
pkg/cmd/addon/index.go 42.10% 9 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
+ Coverage   43.12%   43.17%   +0.04%     
==========================================
  Files         222      223       +1     
  Lines       28351    28431      +80     
==========================================
+ Hits        12227    12275      +48     
- Misses      14614    14639      +25     
- Partials     1510     1517       +7
Flag Coverage Δ
unittests 43.17% <60.86%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added size/L Denotes a PR that changes 100-499 lines. and removed size/XL Denotes a PR that changes 500-999 lines. labels Nov 20, 2023
@1aal 1aal marked this pull request as ready for review November 20, 2023 02:24
ldming
ldming reviewed Nov 21, 2023
View reviewed changes
pkg/cmd/addon/search.go Outdated Show resolved Hide resolved
ldming
ldming reviewed Nov 21, 2023
View reviewed changes
pkg/cmd/addon/search_test.go Show resolved Hide resolved
pkg/cmd/addon/search.go Show resolved Hide resolved
@1aal 1aal merged commit 1da4750 into main Nov 25, 2023
12 checks passed
@1aal 1aal deleted the support/addon-search branch November 25, 2023 02:27
@github-actions github-actions bot added this to the Release 0.8.0 milestone Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldming ldming ldming approved these changes

@nayutah nayutah Awaiting requested review from nayutah nayutah is a code owner

@heng4fun heng4fun Awaiting requested review from heng4fun heng4fun is a code owner

@free6om free6om Awaiting requested review from free6om free6om is a code owner

@wangyelei wangyelei Awaiting requested review from wangyelei wangyelei is a code owner

@leon-inf leon-inf Awaiting requested review from leon-inf leon-inf is a code owner

Assignees
No one assigned
Labels
size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
Release 0.8.0
Development

Successfully merging this pull request may close these issues.

[Features] addon search
3 participants
@1aal @codecov-commenter @ldming