Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support: refactor embed charts to source #115

Closed
wants to merge 7 commits into from

Conversation

lynnleelhl
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the size/XXL Denotes a PR that changes 1000+ lines. label Dec 18, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 40 lines in your changes are missing coverage. Please review.

Comparison is base (2b2ac31) 43.00% compared to head (0950402) 42.88%.
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/util/helm/load.go 0.00% 33 Missing ⚠️
pkg/cluster/builtin_charts.go 53.84% 6 Missing ⚠️
pkg/cluster/cluster_chart.go 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #115      +/-   ##
==========================================
- Coverage   43.00%   42.88%   -0.13%     
==========================================
  Files         228      229       +1     
  Lines       29158    29137      -21     
==========================================
- Hits        12539    12495      -44     
- Misses      15080    15111      +31     
+ Partials     1539     1531       -8     
Flag Coverage Δ
unittests 42.88% <25.92%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lynnleelhl lynnleelhl closed this Dec 18, 2023
@github-actions github-actions bot added this to the Release 0.8.0 milestone Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants