Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: specifying namespace on ops cmds. #490

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

yipeng1030
Copy link
Contributor

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Nov 19, 2024
@github-actions github-actions bot added size/S Denotes a PR that changes 10-29 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Nov 19, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Project coverage is 42.66%. Comparing base (9584c24) to head (a8ea2ae).

Files with missing lines Patch % Lines
pkg/cmd/cluster/operations.go 45.45% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #490   +/-   ##
=======================================
  Coverage   42.66%   42.66%           
=======================================
  Files         172      172           
  Lines       23276    23276           
=======================================
  Hits         9931     9931           
  Misses      12210    12210           
  Partials     1135     1135           
Flag Coverage Δ
unittests 42.66% <45.45%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@yipeng1030 yipeng1030 merged commit 0c1c1e3 into main Nov 19, 2024
12 checks passed
@yipeng1030 yipeng1030 deleted the bugfix/fix_kbcli_cluster_vscale branch November 19, 2024 09:25
@github-actions github-actions bot added this to the Release 1.0 milestone Nov 19, 2024
@yipeng1030
Copy link
Contributor Author

/cherry-pick release-1.0

Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kbcli/actions/runs/11910012476

github-actions bot pushed a commit that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]1.0 kbcli cluster vscale failed if the cluster is set to a non-default namespace
3 participants