Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix specifying namespace is not working #489

Merged
merged 2 commits into from
Nov 18, 2024
Merged

fix: fix specifying namespace is not working #489

merged 2 commits into from
Nov 18, 2024

Conversation

yipeng1030
Copy link
Contributor

@yipeng1030 yipeng1030 commented Nov 18, 2024 •
edited
Loading

fix apecloud/kubeblocks#8448

What' changed?

  • New a factory in buildCustomOpsCmds when trying to list resources by dynamic client.

Why?

  • The buildCustomOpsCmds() function uses a dynamic client built from the factory, which loads the kubeconfig and ignores the overriding flags like --namespace=. This results in a bug where specifying the namespace does not work as expected.

@github-actions github-actions bot added the size/M Denotes a PR that changes 30-99 lines. label Nov 18, 2024
@yipeng1030 yipeng1030 marked this pull request as ready for review November 18, 2024 09:13
@yipeng1030 yipeng1030 merged commit 9584c24 into main Nov 18, 2024
16 of 17 checks passed
@yipeng1030 yipeng1030 deleted the bugfix/fix_kbcli_cluster_list-instances branch November 18, 2024 09:24
@github-actions github-actions bot added this to the Release 1.0 milestone Nov 18, 2024
@yipeng1030
Copy link
Contributor Author

/cherry-pick release-1.0

@github-actions GitHub Actions
Copy link

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/apecloud/kbcli/actions/runs/11889447716

github-actions bot pushed a commit that referenced this pull request Nov 18, 2024
@yipeng1030
fix: fix specifying namespace is not working (#489)
edabe28 
Co-authored-by: yipeng1030 <[email protected]>
(cherry picked from commit 9584c24)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wangyelei wangyelei wangyelei approved these changes

@nayutah nayutah Awaiting requested review from nayutah nayutah is a code owner

@ldming ldming Awaiting requested review from ldming ldming is a code owner

@heng4fun heng4fun Awaiting requested review from heng4fun heng4fun is a code owner

@free6om free6om Awaiting requested review from free6om free6om is a code owner

@leon-inf leon-inf Awaiting requested review from leon-inf leon-inf is a code owner

@1aal 1aal Awaiting requested review from 1aal 1aal is a code owner

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
Release 1.0
Development

Successfully merging this pull request may close these issues.

[BUG]1.0 kbcli cluster list-instances failed If the cluster is set to a non-default namespace
2 participants
@yipeng1030 @wangyelei