From 844002c47f48b5f735b1764cc728535be3f6e5da Mon Sep 17 00:00:00 2001 From: "L.Dongming" Date: Tue, 14 Nov 2023 10:24:22 +0800 Subject: [PATCH 1/2] chore: add code owner and modify github issue assigness (#38) --- .github/CODEOWNERS | 2 +- .github/ISSUE_TEMPLATE/bug_report.md | 2 +- .github/ISSUE_TEMPLATE/feature_request.md | 2 +- .github/ISSUE_TEMPLATE/improvement-request.md | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index b0fe80494..07d947853 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1 +1 @@ -* @nayutah @ldming @heng4fun @free6om @wangyelei @leon-inf +* @nayutah @ldming @heng4fun @free6om @wangyelei @leon-inf @1aal diff --git a/.github/ISSUE_TEMPLATE/bug_report.md b/.github/ISSUE_TEMPLATE/bug_report.md index 4373dc581..6c4e2ba06 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.md +++ b/.github/ISSUE_TEMPLATE/bug_report.md @@ -3,7 +3,7 @@ name: Bug report about: Create a report to help us improve title: "[BUG]" labels: kind/bug -assignees: nayutah +assignees: ldming --- diff --git a/.github/ISSUE_TEMPLATE/feature_request.md b/.github/ISSUE_TEMPLATE/feature_request.md index 8a4eedbf8..de3d7fcc0 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.md +++ b/.github/ISSUE_TEMPLATE/feature_request.md @@ -3,7 +3,7 @@ name: Feature request about: Suggest a user related feature for this project title: "[Features]" labels: area/user-interaction, documentation, kind/feature -assignees: nayutah +assignees: ldming --- diff --git a/.github/ISSUE_TEMPLATE/improvement-request.md b/.github/ISSUE_TEMPLATE/improvement-request.md index c1e26b9e5..bd556296a 100644 --- a/.github/ISSUE_TEMPLATE/improvement-request.md +++ b/.github/ISSUE_TEMPLATE/improvement-request.md @@ -3,7 +3,7 @@ name: Improvement request about: Suggest an improvement idea for this project title: "[Improvement]" labels: kind/enhancement -assignees: nayutah +assignees: ldming --- From 068e85ade85eaa7b088c506e5042bb0d6046563b Mon Sep 17 00:00:00 2001 From: a le <101848970+1aal@users.noreply.github.com> Date: Tue, 14 Nov 2023 13:24:22 +0800 Subject: [PATCH 2/2] chore: fix make-test fail (#39) --- pkg/action/edit_test.go | 2 +- pkg/action/patch_test.go | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/pkg/action/edit_test.go b/pkg/action/edit_test.go index 0abc3fcbf..6b1a4ba58 100644 --- a/pkg/action/edit_test.go +++ b/pkg/action/edit_test.go @@ -37,7 +37,7 @@ import ( "github.com/apecloud/kbcli/pkg/types" ) -var _ = Describe("List", func() { +var _ = Describe("Edit", func() { var ( streams genericiooptions.IOStreams tf *cmdtesting.TestFactory diff --git a/pkg/action/patch_test.go b/pkg/action/patch_test.go index 81fddb013..6ee655ff4 100644 --- a/pkg/action/patch_test.go +++ b/pkg/action/patch_test.go @@ -55,11 +55,11 @@ var _ = Describe("Patch", func() { It("run", func() { cmd := &cobra.Command{} - o := NewPatchOptions(tf, streams, types.ClusterGVR()) - o.Names = []string{"c1"} + o := NewPatchOptions(tf, streams, types.CRDGVR()) + o.Names = []string{"test"} o.AddFlags(cmd) - o.Patch = "{terminationPolicy: Delete}" + // The resource "CRD" expect not found in mock K8s Expect(o.Run(cmd)).Should(HaveOccurred()) }) })