Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQLDeleteCompiler uses isinstance(AutoField) #1

Open
wkornewald opened this issue Sep 25, 2010 · 0 comments
Open

SQLDeleteCompiler uses isinstance(AutoField) #1

wkornewald opened this issue Sep 25, 2010 · 0 comments

Comments

@wkornewald
Copy link

The SQLDeleteCompiler should check the pk column (similar to SQLInsertCompiler) instead of using isinstance. Primary keys can be CharField or other fields if the user overrides the pk. The AutoField check would fail to work in those cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wkornewald