[TOPI] Memoize winograd matrix #3687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cbalint13 please approve |
|
Looks very good to me. |
cbalint13
approved these changes
Aug 1, 2019
cbalint13
reviewed
Aug 1, 2019
|
@merrymercy please act on @cbalint13 's comment |
|
It is resolved. |
tqchen
added
status: accepted
and removed
status: need update
|
Thanks @cbalint13 @merrymercy ! |
wweic
pushed a commit
to wweic/tvm
that referenced
this pull request
Aug 9, 2019
* [TOPI] Memoize winograd matrix * lint * Fix name
wweic
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 6, 2019
* [TOPI] Memoize winograd matrix * lint * Fix name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found #3553 makes feature extraction for arm cpu about 4x slower, which will cause tuning about 2x slower.
Memoizing winograd matrix computation can fix this performance regression, and is slightly faster the the original hard-coded one.