Add null guards for TsFileExecutor constructor #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The inputs to the constructor of `TsFileExecutor` is immediately saved to the executor's private properties, which cannot neither be changed elsewhere nor are they guarded against `null` in other methods of the class. This commit adds guards such for a fail-fast guard against `null` inputs.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
The inputs to the constructor of `TsFileExecutor` is immediately saved to the executor's private properties, which cannot neither be changed elsewhere nor are they guarded against `null` in other methods of the class. This commit adds guards such for a fail-fast guard against `null` inputs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
(Copied from Apache IoTDB PR#12013.)
This PR intends to provide
nullguards in theTsFileExecutor's constructors.The inputs to the constructor of
TsFileExecutorare immediately saved to the executor's private properties, which cannot neither be changed elsewhere nor are they guarded againstnullin other methods of the class.Even though
nullinputs to the constructor make little sense, allowing them to benullmakes debugging any subsequentNullPointerExceptions convoluted.This PR uses the
Object.requireNonNullmethod for a fail-fast guard againstnullinputs.This PR has:
for an unfamiliar reader.
for code coverage.
Key changed/added classes (or packages if there are too many classes) in this PR