Add some constructor for chunk capacity #180
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
133tosakarin
force-pushed
the
add_some_constructor_for_chunk_capacity
branch
from
1c49df3
to
5fe593f
Compare
| @@ -170,6 +204,11 @@ public int write(Tablet tablet) throws WriteProcessException, IOException { | |||
| emptyValueChunkWriters.add(entry.getValue()); | |||
| } | |||
| } | |||
|
|
|||
| for (int columnIndex = 0; columnIndex < measurementSchemas.size(); ++columnIndex) { | |||
| @@ -80,6 +80,36 @@ public AlignedChunkWriterImpl(VectorMeasurementSchema schema) { | |||
| this.remainingPointsNumber = timeChunkWriter.getRemainingPointNumberForCurrentPage(); | |||
| } | |||
|
|
|||
| public AlignedChunkWriterImpl(VectorMeasurementSchema schema, int rowCount) { | |||
|
|
|||
| rowCount); | ||
|
|
||
| this.valueIndex = 0; | ||
|
|
| // init statistics for this chunk and page | ||
| this.statistics = Statistics.getStatsByType(dataType); | ||
|
|
||
| int bufferCount = |
There was a problem hiding this comment.
abstract function and add comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ChunkWriter, we add some constructor with rowCount params to specific the capacity of bytestream such that we can reduce the bytestream grow times.
Note: these constructors are used just in iotdb currently