BZ69355: ExactRateLimiter #767
Conversation
1. Accurate rate controller. 2. exposeHeaders
remove unused imports
add License Header
make expose headers follows draft-ietf-httpapi-ratelimit-headers spec.
|
@markt-asf @rmaucher wondering if this PR is appropriate? tks. |
| public final int getCurrentBucketPrefix() { | ||
| return (int) (System.currentTimeMillis() >> this.numBits); | ||
| public final int getBucketPrefix(long timestamp) { | ||
| return (int) (timestamp >> this.numBits); |
There was a problem hiding this comment.
Why make this change? It appears to increase code duplication with no obvious benefit.
|
|
||
| /** | ||
| * Returns the identifier from the servlet request, which used to work as rate limit by. | ||
| * @param request | ||
| * @return identifier | ||
| */ | ||
| protected String getLimitByIdentifier(ServletRequest request) { | ||
| return request.getRemoteAddr(); | ||
| } | ||
|
|
||
| @Override | ||
| public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain) | ||
| throws IOException, ServletException { | ||
|
|
||
| String ipAddr = request.getRemoteAddr(); | ||
| int reqCount = rateLimiter.increment(ipAddr); | ||
| String identifier = getLimitByIdentifier(request); | ||
| int reqCount = rateLimiter.increment(identifier); |
There was a problem hiding this comment.
This looks like another, possibly separate, improvement.
| timebucket.maintenance.error=定期维护时出现错误 | ||
| exactRateLimiter.maintenance.error=定期维护时出现错误 |
There was a problem hiding this comment.
Can you re-use timebucket.maintenance.error here?
| /** | ||
| * An accurate fixed window limiter. | ||
| */ | ||
| public class ExactRateLimiter implements RateLimiter { |
There was a problem hiding this comment.
It looks like there is scope for a common base class for this class and FastRateLimiter
@markt-asf smaller PRs came, first one is #775 . |
|
No changes to merge here. Looking forward to additional PRs. |
|
another one next week. |
replace #760: redo pr , change src branche from "main" to a dedicated branch "main_BZ69355".
for headers section, compliance with draft spec of "https://datatracker.ietf.org/doc/draft-ietf-httpapi-ratelimit-headers ".
comparing with no-ratelimit / or fast-ratelimiter, ab test of exact-ratelimiter performance shows that no significant throughout decrease (about -2% / -1%).