[Core] Support alter database #4700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerry-024
force-pushed
the
rest-catalog
branch
from
3e184ab to
1be2269
Compare
jerry-024
changed the title
jerry-024
force-pushed
the
rest-catalog
branch
from
530f4fc to
8593c06
Compare
…CreateDatabaseReques fix RESTCatalog fix checkstyle fail fix error change in RESTCatalog
…o support get set and remove from change
jerry-024
force-pushed
the
rest-catalog
branch
from
8593c06 to
8b97cf7
Compare
… database when operation on a database fix typo
jerry-024
force-pushed
the
rest-catalog
branch
from
4cfcdac to
240c30b
Compare
JingsongLi
reviewed
Dec 16, 2024
JingsongLi
reviewed
Dec 16, 2024
JingsongLi
reviewed
Dec 16, 2024
paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/FlinkCatalog.java
Show resolved
Hide resolved
…reate database in flink
JingsongLi
reviewed
Dec 16, 2024
| The following SQL sets one or more properties in the specified database. If a particular property is already set in the database, override the old value with the new one. | ||
|
|
||
| ```sql | ||
| ALTER DATABASE [catalog_name.]db_name SET (key1=val1, key2=val2, ...) |
There was a problem hiding this comment.
Add example to alter comment and location.
There was a problem hiding this comment.
As in flink sql couldn't alter comment for the database, so we could only alter the location.
JingsongLi
reviewed
Dec 16, 2024
| The following SQL sets one or more properties in the specified database. If a particular property is already set in the database, override the old value with the new one. | ||
|
|
||
| ```sql | ||
| ALTER { DATABASE | SCHEMA | NAMESPACE } my_database |
There was a problem hiding this comment.
Add example to alter comment and location.
JingsongLi
reviewed
Dec 16, 2024
| try { | ||
| Database oldDatabase = catalog.getDatabase(name); | ||
| List<PropertyChange> changes = | ||
| getPropertyChanges(oldDatabase.options(), newDatabase.getProperties()); |
There was a problem hiding this comment.
Here should extract comment from newDatabase?
JingsongLi
reviewed
Dec 16, 2024
| @Override | ||
| public void alterNamespace(String[] namespace, NamespaceChange... changes) { | ||
| throw new UnsupportedOperationException("Alter namespace in Spark is not supported yet."); | ||
| public void alterNamespace(String[] namespace, NamespaceChange... changes) |
There was a problem hiding this comment.
Add test in DDLWithHiveCatalogTestBase?
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Support alter database
Linked issue: #4540
Tests
API and Format
Documentation