[core] Supports skipping specified actions during writing. #4884
Conversation
LinMingQiang
force-pushed
the
master-feat-addconf-toskip-action
branch
2 times, most recently
from
9d3fcef to
ed49eb8
Compare
|
Thanks for @LinMingQiang prepare this pr. |
LinMingQiang
force-pushed
the
master-feat-addconf-toskip-action
branch
from
7250389 to
b3867f8
Compare
|
+1 |
| <td><h5>write.skip-actions</h5></td> | ||
| <td style="word-wrap: break-word;">(none)</td> | ||
| <td>String</td> | ||
| <td>This parameter only works when write-only is false., You can specify which actions to skip during the write process.<br />1. 'partition-expire': Skip the action of partition expiration.<br />2. 'snapshot-expire': Skip the action of snapshot expiration.<br />3. 'create-tag': Skip automatic tag creation.<br />Both can be configured at the same time: 'partition-expire,snapshot-expire,create-tag'.</td> |
There was a problem hiding this comment.
I prefer to add a separate enable conf for each such post-commit behavior, with the default set to true.
There was a problem hiding this comment.
Thanks for review, If the parameters are separated, will it be more cumbersome to use ? For my needs, I need to skip partition-expire & snapshot-expire & create tag but retain compact, so I may need to configure three parameters to meet my needs.
There was a problem hiding this comment.
Maybe you can add a write-actions? Default is 'all'. The values can be:
snapshot-expire, partition-expire, compaction, tag-automatic-creation.
There was a problem hiding this comment.
Does this compact mean full or minor or both, or should it be separated into two actions full_compact and minor_compact?
There was a problem hiding this comment.
maybe full or minor should be separate option.
There was a problem hiding this comment.
Ok, I will fix it.
LinMingQiang
force-pushed
the
master-feat-addconf-toskip-action
branch
from
b3867f8 to
99dcebd
Compare
LinMingQiang
force-pushed
the
master-feat-addconf-toskip-action
branch
3 times, most recently
from
0e09ce9 to
0c0573a
Compare
LinMingQiang
force-pushed
the
master-feat-addconf-toskip-action
branch
from
0c0573a to
7cb026d
Compare
Purpose
There are several operations during data writing such as
partition-expire,snapshot-expire,create-tag...Currently, these actions are either executed together or not executed at all in the framework.
The purpose of this PR is to supports skipping specified actions during writing.
For example : set
'write.skip-actions'='partition-expire', the partition expiration action will be skipped during data writing, butsnapshot-expire/auto create tag/full compactwill still execute normally.Linked issue: close #xxx
Tests
API and Format
Documentation