[core] Support partition API #4786
Conversation
dropPartition throw exception when table is nul
jerry-024
force-pushed
the
rest-catalog
branch
from
bcc4ef1 to
427f5a7
Compare
| private final Map<String, String> spec; | ||
|
|
||
| @JsonProperty(FIELD_PARTITION_TYPE) | ||
| private final RowType partitionType; |
There was a problem hiding this comment.
Do not add type in this class.
jerry-024
force-pushed
the
rest-catalog
branch
from
af813a6 to
4ec183c
Compare
| checkNotSystemTable(identifier, "dropPartition"); | ||
| dropPartitionMetadata(identifier, partitions); | ||
| Table table = getTable(identifier); | ||
| if (table != null) { |
There was a problem hiding this comment.
it is null? I think maybe getTable will throw TableNotExistsException.
| @@ -71,4 +71,10 @@ public class RESTCatalogOptions { | |||
| .stringType() | |||
| .noDefaultValue() | |||
| .withDescription("REST Catalog auth token provider path."); | |||
|
|
|||
| public static final ConfigOption<Boolean> METASTORE_PARTITIONED = | |||
There was a problem hiding this comment.
Use CoreOptions.metastore.partitioned-table.
| resourcePaths.partitions( | ||
| identifier.getDatabaseName(), identifier.getTableName()), | ||
| request, | ||
| SuccessResponse.class, |
There was a problem hiding this comment.
here should return Partition?
| request, | ||
| headers()); | ||
| } catch (NoSuchResourceException ignore) { | ||
| return new SuccessResponse(); |
There was a problem hiding this comment.
I think here should throw table not exist exception?
There was a problem hiding this comment.
when the partition's metadata doesn't exist in metadata, there may still be data in the filesystem. So we ignore this exception when dropping the partition.
There was a problem hiding this comment.
should return false instead of NoSuchResourceException?
| throws TableNoPermissionException { | ||
| try { | ||
| DropPartitionRequest request = new DropPartitionRequest(partitions); | ||
| return client.delete( |
There was a problem hiding this comment.
we should return Partition?
| @@ -434,6 +524,23 @@ protected GetTableResponse getTableResponse(Identifier identifier) | |||
| } | |||
| } | |||
|
|
|||
| protected boolean dropPartitionMetadata(Identifier identifier, Map<String, String> partitions) | |||
There was a problem hiding this comment.
Why need these tests invoking this method? Why not invoking catalog methods?
|
+1 |
Purpose
Support partition API
Linked issue: #4540
Tests
API and Format
Documentation