Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rest] Fix GetTableResponse should return fields #4769

Merged
merged 4 commits into from
Dec 25, 2024

Conversation

JingsongLi
Copy link
Contributor

@JingsongLi JingsongLi commented Dec 24, 2024

Purpose

Modify GetTableResponse:

public class GetTableResponse implements RESTResponse {

    private static final String FIELD_PATH = "path";
    private static final String FIELD_SCHEMA_ID = "schema-id";
    private static final String FIELD_SCHEMA = "schema";

    @JsonProperty(FIELD_PATH)
    private final String path;

    @JsonProperty(FIELD_SCHEMA_ID)
    private final long schemaId;

    @JsonProperty(FIELD_SCHEMA)
    private final Schema schema;
}

We should use Schema instead of TableSchema to keep one serialization implementation.

UpdateTable to RenameTable

UpdateTable should be refactored, because we need a unified SchemaChange to support changes.

Tests

API and Format

Documentation

@wwj6591812
Copy link
Contributor

+1

1 similar comment
@jerry-024
Copy link
Contributor

+1

@JingsongLi JingsongLi merged commit bf58ddd into apache:master Dec 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants