Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] External Path in DataFileMeta should be the file path #4766

Merged
merged 2 commits into from
Dec 24, 2024
Merged

[core] External Path in DataFileMeta should be the file path #4766

merged 2 commits into from
Dec 24, 2024

Conversation

JingsongLi
Copy link
Contributor

Purpose

Fix after #4761

  • External Path in DataFileMeta should be the file path instead of directory.
  • And clean interface methods.

Tests

API and Format

Documentation

@neuyilan
Copy link
Member

LGTM

@JingsongLi JingsongLi merged commit 4ac05e4 into apache:master Dec 24, 2024
12 checks passed
JingsongLi added a commit that referenced this pull request Dec 24, 2024
@JingsongLi
[core] External Path in DataFileMeta should be the file path (#4766)
1624678
@neuyilan neuyilan mentioned this pull request Dec 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JingsongLi @neuyilan