Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Skip case checking in catalog #4730

Merged
merged 3 commits into from
Dec 18, 2024
Merged

Conversation

Zouxxyy
Copy link
Contributor

@Zouxxyy Zouxxyy commented Dec 17, 2024

Purpose

Checked with iceberg and delta, they don't check the case of tables or fields with hive in catalog.

So skip case checking in paimon too, and let the catalog implementation do case checking itself.

For example, table names are always lowercase in hive, so when creating a table with the same lowercase with hive catalog, hive will throw an exception:

create table t;
-- table exists exception
create table T;

Tests

API and Format

Documentation

@Zouxxyy Zouxxyy closed this Dec 17, 2024
@Zouxxyy Zouxxyy reopened this Dec 17, 2024
@Zouxxyy Zouxxyy force-pushed the dev/case-sens branch 4 times, most recently from b2f9759 to 1c10fd0 Compare December 17, 2024 13:54
@Zouxxyy Zouxxyy changed the title [WIP][core] Enable catalog case-sensitive by default [core] Enable catalog case-sensitive by default Dec 17, 2024
@JingsongLi
Copy link
Contributor

I think it is not enable catalog case-sensitive by default, we should remove checking for case-sensitive?

@Zouxxyy Zouxxyy changed the title [core] Enable catalog case-sensitive by default [core] Skip case checking in catalog Dec 18, 2024
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit 2db0281 into apache:master Dec 18, 2024
12 checks passed
@Zouxxyy Zouxxyy deleted the dev/case-sens branch December 18, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants