-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core]: Improve fault tolerance for data spill to disk #4675
Merged
JingsongLi
merged 1 commit into
apache:master
from
zhongyujiang:gh/improve-file-channel-manager
Dec 10, 2024
Merged
[core]: Improve fault tolerance for data spill to disk #4675
JingsongLi
merged 1 commit into
apache:master
from
zhongyujiang:gh/improve-file-channel-manager
Dec 10, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI failure seems unreleated
|
JingsongLi
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Paimon may spill data to the local temporary directory, but the disk where the temporary directory is located may become damaged during running (marked as read-only or otherwise), which can cause tasks to fail due to unsuccessful spills, when restarting, failure may still occur due to the bad disk.
In actual production, jobs are often configured with multiple temporary directories, so as long as the number of available cache directories for Paimon is greater than 0, it is acceptable even if the disks of some directories are unavailable.
This PR changes the behavior of
FileChannelManagerImpl
to log a warning instead of throwing an exception directly when encountering a bad disk, which improves the fault tolerance of the job.@JingsongLi Could you please take a look? Thanks.
Tests
API and Format
No
Documentation
No