[core] Fix parquet nextRowPosition bug #4636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leaves12138
changed the title
|
@Aiden-Dong Can you create unit tests to cover this? |
I'm going to add a range query test to cover this case. |
xuzifu666
reviewed
Dec 4, 2024
| @@ -822,6 +843,8 @@ public void testDeletionVectorsWithParquetFilter() throws Exception { | |||
| conf.set("parquet.page.size", "1024"); | |||
| }); | |||
|
|
|||
| System.out.println(((AbstractFileStoreTable) table).path); | |||
There was a problem hiding this comment.
Change to LOG info or remove it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: #4608 (comment)
Tests
API and Format
Documentation