Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spark] show table extended #4603

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

YannByron
Copy link
Contributor

Purpose

to support SHOW TABLE EXTENDED ((FROM | IN) ns=identifierReference)? LIKE pattern=stringLit partitionSpec? syntax.

Linked issue: close #xxx

Tests

API and Format

Documentation

@JingsongLi
Copy link
Contributor

Thanks @YannByron , Can you also modify documentation?

@xuzifu666
Copy link
Member

Nice Job,seems SparkSQL had not supported with the v2 syntax yet.

@xuzifu666
Copy link
Member

+1, left some minor comments.

@YannByron
Copy link
Contributor Author

Nice Job,seems SparkSQL had not supported with the v2 syntax yet.

Spark supports it for v2 table in 4.x. So I just need do this for spark 3.x.

@YannByron
Copy link
Contributor Author

Thanks @YannByron , Can you also modify documentation?

added.

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@xuzifu666 xuzifu666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1


implicit class PaimonNamespaceHelper(namespace: Array[String]) extends NamespaceHelper(namespace)

// implicit class PaimonTableHelper(table: Table) extends TableHelper(table)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line can be deleted.

private def getTableDetails(catalogName: String, identifier: Identifier, table: Table): String = {
val results = new mutable.LinkedHashMap[String, String]()

results.put("Catalog", catalogName)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Catalog", "Namespace","Table" change to constant ?

@xuzifu666 xuzifu666 merged commit 300cc67 into apache:master Dec 3, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants