[core] RollingFileWriter#abort shouldn't abort currentWriter twice

[yuzelin]

Purpose

For example, currentWriter#write occurs exception E1, it will abort, then the RollingFileWriter#abort will abort currentWriter again. Some OutputStream cannot be closed twice, so it will throw an new exception E2 which covers E1.

Tests

API and Format

Documentation

[wwj6591812]

I think the second call to RollingFileWriter#abort is in RollingFileWriter#write's catch statement.
But where was the first call to RollingFileWriter#abort?

[yuzelin]

I think the second call to RollingFileWriter#abort is in RollingFileWriter#write's catch statement. But where was the first call to RollingFileWriter#abort?

I mean RollingFileWriter will call currentWriter#abort when #write has exception, then it will call currentWriter#abort again.

[JingsongLi]

You modify SingleFileWriter

    @Override
    public void abort() {
        if (out != null) {
            IOUtils.closeQuietly(out);
            out = null;
        }
        fileIO.deleteQuietly(path);
    }

[wwj6591812]

+1

[wwj6591812]

I think the second call to RollingFileWriter#abort is in RollingFileWriter#write's catch statement. But where was the first call to RollingFileWriter#abort?

I mean RollingFileWriter will call currentWriter#abort when #write has exception, then it will call currentWriter#abort again.

OK, Thinks.
The first time is in RollingFileWriter#write -> SingleFileWriter#write -> SingleFileWriter#writeImpl -> SingleFileWriter#abort.
The second time is in RollingFileWriter#write -> RollingFileWriter#abort -> SingleFileWriter#abort.

[yuzelin]

Fixed in #4547