[core] Introduce InPredicateVisitor to refactor Predicate handle #4486
Conversation
| break; | ||
| } | ||
| } | ||
| Optional<List<Object>> leafs = |
There was a problem hiding this comment.
Why here has no judge of : (compoundPredicate.function() instanceof Or) ?
But SchemasTable and TagsTable both judged?
| Optional<List<Object>> leafs = | ||
| InPredicateVisitor.extractInElements(predicate, TAG_NAME); | ||
| if (leafs.isPresent()) { | ||
| leafs.get().stream() | ||
| .forEach( | ||
| leaf -> { | ||
| if (tagManager.tagExists(leaf.toString())) { | ||
| predicateMap.put( | ||
| leaf.toString(), | ||
| tagManager.tag(leaf.toString())); | ||
| } | ||
| }); |
There was a problem hiding this comment.
InPredicateVisitor.extractInElements(predicate, TAG_NAME) .ifPresent(leafs -> leafs .forEach( leaf -> { String leftName = leaf.toString(); if (tagManager.tagExists(leftName)) { predicateMap.put( leftName, tagManager.tag(leftName)); } }));
| Optional<List<Object>> leafs = | ||
| InPredicateVisitor.extractInElements(predicate, leafName); | ||
| if (leafs.isPresent()) { | ||
| leafs.get().stream() | ||
| .forEach(leaf -> snapshotIds.add(Long.parseLong(leaf.toString()))); |
There was a problem hiding this comment.
InPredicateVisitor.extractInElements(predicate, leafName)
.ifPresent(leafs -> leafs
.forEach(leaf -> snapshotIds.add(Long.parseLong(leaf.toString()))));
| Optional<List<Object>> leafs = | ||
| InPredicateVisitor.extractInElements(predicate, leafName); | ||
| if (leafs.isPresent()) { | ||
| leafs.get().stream() | ||
| .forEach(leaf -> schemaIds.add(Long.parseLong(leaf.toString()))); |
There was a problem hiding this comment.
InPredicateVisitor.extractInElements(predicate, leafName) .ifPresent(leafs -> leafs .forEach(leaf -> schemaIds.add(Long.parseLong(leaf.toString()))));
| public class InPredicateVisitor { | ||
|
|
||
| /** | ||
| * Method for handling with CompoundPredicate. |
There was a problem hiding this comment.
Method for handling with In CompoundPredicate
|
@wwj6591812 had addressed, Thanks. |
|
+1 |
Purpose
Linked issue: close #xxx
from: #4469
Tests
API and Format
Documentation