Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Fix merge schemas equal method issue #4482

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Conversation

harveyyue
Copy link
Contributor

Purpose

Linked issue: close #xxx
No

Tests

API and Format

Documentation

@wwj6591812
Copy link
Contributor

+1

@JingsongLi
Copy link
Contributor

I remember this is not an issue. @harveyyue Can you find the exact case?

@harveyyue
Copy link
Contributor Author

I remember this is not an issue. @harveyyue Can you find the exact case?

Using spark format paimon to write upstream data will generate a new schema-xxx since have no schema changes
dataset.format("paimon").options(options);

@JingsongLi
Copy link
Contributor

I remember this is not an issue. @harveyyue Can you find the exact case?

Using spark format paimon to write upstream data will generate a new schema-xxx since have no schema changes dataset.format("paimon").options(options);

@harveyyue Can you add a test case?

@harveyyue
Copy link
Contributor Author

harveyyue commented Nov 11, 2024

I remember this is not an issue. @harveyyue Can you find the exact case?

Using spark format paimon to write upstream data will generate a new schema-xxx since have no schema changes dataset.format("paimon").options(options);

@harveyyue Can you add a test case?

Done
We did some code changes to reselect column according table schema, the unexecpted field orders will trigger the == compare method from row type.

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi JingsongLi merged commit 70b2d0c into apache:master Nov 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants