[core] Introduce RollbackToTimestamp Procedure and Action #4410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| -- for Flink 1.19 and later<br/> | ||
| CALL sys.rollback_to(`table` => 'default.T', snapshot_id => 1730292023000) | ||
| </td> | ||
| </tr> |
There was a problem hiding this comment.
rollback_to -> rollback_to_timestamp
snapshot_id -> timestamp
There was a problem hiding this comment.
My mistake, Thanks! @LinMingQiang
| * Rollback to timestamp procedure. Usage: | ||
| * | ||
| * <pre><code> | ||
| * -- rollback to a snapshot |
There was a problem hiding this comment.
rollback to the snapshot which earlier or equal than timestamp.
| String.format("count not find snapshot earlier than %s", timestamp)); | ||
| fileStoreTable.rollbackTo(snapshot.id()); | ||
| InternalRow outputRow = newInternalRow(true); | ||
| return new InternalRow[] {outputRow}; |
| snapshot, String.format("count not find snapshot earlier than %s", timestamp)); | ||
| fileStoreTable.rollbackTo(snapshot.id()); | ||
|
|
||
| return new String[] {"Success"}; |
There was a problem hiding this comment.
Show which snapshot id to roll back to
| Preconditions.checkNotNull( | ||
| snapshot, String.format("count not find snapshot earlier than %s", timestamp)); | ||
| fileStoreTable.rollbackTo(snapshot.id()); | ||
| return new String[] {"Success"}; |
|
|
||
| public String[] call(ProcedureContext procedureContext, String tableId, long timestamp) | ||
| throws Catalog.TableNotExistException { | ||
| Table table = catalog.getTable(Identifier.fromString(tableId)); |
There was a problem hiding this comment.
check table not empty
|
@LinMingQiang had addressed, Thanks |
|
+1 |
JingsongLi
approved these changes
Oct 31, 2024
hang8929201
pushed a commit
to hang8929201/paimon
that referenced
this pull request
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #xxx
Currently Rollback cannot rollback according timestamp which can make user more easy to rollback, as #4333 suggest introduce RollbackToTimestamp to support for procedure and action.
Tests
API and Format
Documentation