[hive]add retention seconds in hive catalog. #4367
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwj6591812
reviewed
Oct 24, 2024
| @@ -814,6 +814,11 @@ private Table newHmsTable( | |||
| if (provider == null) { | |||
| provider = "paimon"; | |||
| } | |||
| CoreOptions coreOptions = CoreOptions.fromMap(tableParameters); | |||
There was a problem hiding this comment.
Duration partitionExpireTime = coreOptions.partitionExpireTime();
| int retention = | ||
| coreOptions.partitionExpireTime() == null | ||
| ? Integer.MAX_VALUE | ||
| : (int) coreOptions.partitionExpireTime().getSeconds(); |
There was a problem hiding this comment.
Is there a risk of data overflow here？
getSeconds return long, then cast int.
|
Can you provide the specific application of this attribute? For example, Hive first introduced it with JIRA, etc. |
JingsongLi
reviewed
Oct 29, 2024
| java.time.Duration partitionExpireTime = coreOptions.partitionExpireTime(); | ||
| int retention = Integer.MAX_VALUE; | ||
| if (partitionExpireTime != null && partitionExpireTime.getSeconds() <= Integer.MAX_VALUE) { | ||
| retention = (int) partitionExpireTime.getSeconds(); |
There was a problem hiding this comment.
Maybe only set it with metastore.partitioned-table enabled.
|
I am not sure this field is for partition retention. Maybe we can use properties to store this option. |
|
Close this first, feel free to re-open this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add
retentionproperties for hive metastore according to 'partition.expiration-time'.Linked issue: close #xxx
Tests
API and Format
Documentation