Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spark] remove the dependency of paimon-bundle in all submodules of paimon-spark. #4352

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

liming30
Copy link
Contributor

Purpose

Linked issue: close #4351

Remove the dependency of paimon-bundle in all submodules of paimon-spark to fix the problem that the paimon class cannot be found in idea.

Tests

API and Format

Documentation

@wwj6591812
Copy link
Contributor

+1

@liming30
Copy link
Contributor Author

@JingsongLi @Zouxxyy can I merge this PR?

@Zouxxyy
Copy link
Contributor

Zouxxyy commented Oct 22, 2024

@JingsongLi @Zouxxyy can I merge this PR?

Sorry for delay, let me test it on my idea 2024

@Zouxxyy
Copy link
Contributor

Zouxxyy commented Oct 22, 2024

I test MigrateFileProcedureTest on my IDEA and it throw this:

An exception or error caused a run to abort: COMPRESSION_ZSTD_LEVEL 
java.lang.NoSuchFieldError: COMPRESSION_ZSTD_LEVEL
	at org.apache.paimon.format.orc.OrcFileFormat.getOrcProperties(OrcFileFormat.java:152)
	at org.apache.paimon.format.orc.OrcFileFormat.<init>(OrcFileFormat.java:75)
	at org.apache.paimon.format.orc.OrcFileFormatFactory.create(OrcFileFormatFactory.java:35)
	at org.apache.paimon.format.orc.OrcFileFormatFactory.create(OrcFileFormatFactory.java:24)
	at org.apache.paimon.format.FileFormat.fromIdentifier(FileFormat.java:106)
	at org.apache.paimon.format.FileFormat.fromIdentifier(FileFormat.java:91)

@liming30
Copy link
Contributor Author

I test MigrateFileProcedureTest on my IDEA and it throw this:

An exception or error caused a run to abort: COMPRESSION_ZSTD_LEVEL 
java.lang.NoSuchFieldError: COMPRESSION_ZSTD_LEVEL
	at org.apache.paimon.format.orc.OrcFileFormat.getOrcProperties(OrcFileFormat.java:152)
	at org.apache.paimon.format.orc.OrcFileFormat.<init>(OrcFileFormat.java:75)
	at org.apache.paimon.format.orc.OrcFileFormatFactory.create(OrcFileFormatFactory.java:35)
	at org.apache.paimon.format.orc.OrcFileFormatFactory.create(OrcFileFormatFactory.java:24)
	at org.apache.paimon.format.FileFormat.fromIdentifier(FileFormat.java:106)
	at org.apache.paimon.format.FileFormat.fromIdentifier(FileFormat.java:91)

@Zouxxyy There is a version conflict with orc-core. When I exclude it, all the tests in idea can run successfully. But when I use mvn to execute in the terminal, an exception occurs that orc classes cannot be found. Do you have any other suggestions?

@Zouxxyy
Copy link
Contributor

Zouxxyy commented Oct 23, 2024

@Zouxxyy There is a version conflict with orc-core. When I exclude it, all the tests in idea can run successfully. But when I use mvn to execute in the terminal, an exception occurs that orc classes cannot be found. Do you have any other suggestions?

@liming30 In fact, I have no other suitable solutions yet. Can you try 1) remove paimon-bundle, 2) exclude orc or parquet deps in spark deps 3) add orc or parquet deps with paimon used version

@Zouxxyy
Copy link
Contributor

Zouxxyy commented Oct 24, 2024

@liming30 Can you try this Zouxxyy@05d3a86

@liming30
Copy link
Contributor Author

@liming30 Can you try this Zouxxyy@05d3a86

Thanks for your help, I'll try this again later.

liming30 and others added 2 commits October 25, 2024 11:08
…aimon-spark.

remove the dependency of paimon-bundle in all submodules of paimon-spark to fix the problem that the paimon class cannot be found in idea.
@liming30
Copy link
Contributor Author

@Zouxxyy There are still some tests that fail in idea, such as org.apache.paimon.spark.procedure.MigrateTableProcedureTest. I will try to solve this problem next.

@askwang
Copy link
Contributor

askwang commented Oct 25, 2024

@Zouxxyy There are still some tests that fail in idea, such as org.apache.paimon.spark.procedure.MigrateTableProcedureTest. I will try to solve this problem next.

@liming30 I tested it ok in my idea, maybe you need rebuild the project

@YannByron
Copy link
Contributor

That works. +1.

@liming30 liming30 merged commit 74a7783 into apache:master Oct 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] idea cannot find classes of other modules in the paimon-spark submodule.
5 participants