Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Rollback action write hint first #4331

Merged
merged 1 commit into from
Oct 20, 2024

Conversation

yuzelin
Copy link
Contributor

@yuzelin yuzelin commented Oct 16, 2024

Purpose

If we start a job when Rollback is running, it may read latest snapshot id from hint file and get wrong snapshot id.
This PR fix it.

Tests

API and Format

Documentation

@wwj6591812
Copy link
Contributor

+1

@yuzelin yuzelin changed the title [core] Rollback action write hint first and use thread pool to delete manifests [core] Rollback action write hint first Oct 17, 2024
Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write description.

@JingsongLi
Copy link
Contributor

+1

@JingsongLi JingsongLi merged commit 87321e1 into apache:master Oct 20, 2024
12 checks passed
@yuzelin yuzelin deleted the refactor_rollback branch December 4, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants