-
Notifications
You must be signed in to change notification settings - Fork 990
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flink] Add CompactManifestProcedure to enable compact manifest manually #4327
Merged
JingsongLi
merged 10 commits into
apache:master
from
leaves12138:Compact_Manifest_Procedure
Oct 20, 2024
Merged
[flink] Add CompactManifestProcedure to enable compact manifest manually #4327
JingsongLi
merged 10 commits into
apache:master
from
leaves12138:Compact_Manifest_Procedure
Oct 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leaves12138
force-pushed
the
Compact_Manifest_Procedure
branch
from
October 15, 2024 07:14
14b14a4
to
3347c1d
Compare
JingsongLi
reviewed
Oct 15, 2024
paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java
Outdated
Show resolved
Hide resolved
JingsongLi
reviewed
Oct 15, 2024
paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java
Outdated
Show resolved
Hide resolved
JingsongLi
reviewed
Oct 15, 2024
...n-flink-common/src/main/java/org/apache/paimon/flink/procedure/ManifestCompactProcedure.java
Outdated
Show resolved
Hide resolved
JingsongLi
reviewed
Oct 15, 2024
...n-flink-common/src/main/java/org/apache/paimon/flink/procedure/ManifestCompactProcedure.java
Outdated
Show resolved
Hide resolved
wwj6591812
reviewed
Oct 15, 2024
...n-flink-common/src/main/java/org/apache/paimon/flink/procedure/CompactManifestProcedure.java
Outdated
Show resolved
Hide resolved
import java.util.Collections; | ||
|
||
/** Compact manifest file to reduce deleted manifest entries. */ | ||
public class CompactManifestProcedure extends ProcedureBase { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not add the Flink CompactManifestAction?
paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommit.java
Show resolved
Hide resolved
JingsongLi
changed the title
[flink] Add ManifestCompactProcedure to enable compact manifest manually
[flink] Add CompactManifestProcedure to enable compact manifest manually
Oct 16, 2024
+1 |
JingsongLi
reviewed
Oct 17, 2024
paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java
Outdated
Show resolved
Hide resolved
JingsongLi
reviewed
Oct 17, 2024
paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java
Outdated
Show resolved
Hide resolved
JingsongLi
reviewed
Oct 17, 2024
paimon-core/src/main/java/org/apache/paimon/operation/FileStoreCommitImpl.java
Show resolved
Hide resolved
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Come up with a flink procedure, which could compact manifest manually.
Tests
API and Format
Documentation