[core] Add Table.uuid method #4213
Conversation
| if (catalogEnvironment.uuid() != null) { | ||
| return catalogEnvironment.uuid(); | ||
| } | ||
| return fullName(); |
There was a problem hiding this comment.
should at least log warning or add a setting to enabling simply use fullName() as uuid()
There was a problem hiding this comment.
We must let this method work at least. Log will produce many logs for filesystem catalog.
There was a problem hiding this comment.
Maybe we can find better implementation for non-hive catalog tables. And system tables.
| if (catalogEnvironment.uuid() != null) { | ||
| return catalogEnvironment.uuid(); | ||
| } | ||
| long earliestCreationTime = schemaManager().earliestCreationTime(); |
There was a problem hiding this comment.
will this earliestCreationTime change as we do compaction or snapshot expire?
There was a problem hiding this comment.
Never, actually we do not clean schema files, so the first schema file (schema-0) will always exist, and immutable.
So this earliestCreationTime should always be the same.
| catalog.createTable(identifier, DEFAULT_TABLE_SCHEMA, false); | ||
| Table table = catalog.getTable(identifier); | ||
| String uuid = table.uuid(); | ||
| assertThat(uuid).startsWith(identifier.getFullName() + "."); |
There was a problem hiding this comment.
This will fail those non-FileStoreTable, right?
|
LGTM, +1, let's merge this! |
Purpose
Add Table.uuid method for table uniq id, this can be used like some RBAC support.
Tests
API and Format
Documentation