Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Improve partition mark done action type documentation #4014

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

zhuangchong
Copy link
Contributor

Purpose

Improve partition mark done action type documentation

Tests

API and Format

Documentation

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @zhuangchong , we still don't know the usage of mark-event, I think it is good to keep it not in documentation.

@zhuangchong
Copy link
Contributor Author

Hi @zhuangchong , we still don't know the usage of mark-event, I think it is good to keep it not in documentation.

The mark-event is to mark the partition completion by the markPartitionForEvent method provided by the hive metastore client.

Then use the hive metastore client's isPartitionMarkedForEvent method to query whether the partition is completed.

image

Copy link
Contributor

@JingsongLi JingsongLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@JingsongLi
Copy link
Contributor

Hi @zhuangchong , we still don't know the usage of mark-event, I think it is good to keep it not in documentation.

The mark-event is to mark the partition completion by the markPartitionForEvent method provided by the hive metastore client.

Then use the hive metastore client's isPartitionMarkedForEvent method to query whether the partition is completed.

image

Make sense, merging...

@JingsongLi JingsongLi merged commit 373d239 into apache:master Aug 21, 2024
11 checks passed
@zhuangchong zhuangchong deleted the doc-partition-mark-done branch August 21, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants