[core] support deletion vector with input ChangelogProducer #3929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wwj6591812
force-pushed
the
support_dv_with_input_changelog_producer_0809
branch
from
fb65352 to
9d13d2c
Compare
JingsongLi
reviewed
Aug 11, 2024
| @@ -33,6 +33,7 @@ public class DeltaFollowUpScanner implements FollowUpScanner { | |||
| @Override | |||
| public boolean shouldScanSnapshot(Snapshot snapshot) { | |||
| if (snapshot.commitKind() == Snapshot.CommitKind.APPEND) { | |||
| System.out.println("here! : " + snapshot.id()); | |||
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1、Now input ChangelogProducer and DeletionVector are decoupled, so change the validate of DeletionVectors.
2、Format some code.
Purpose
Linked issue: close #xxx
Tests
API and Format
Documentation