[spark] Support auto disable bucketed scan #3928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems spark test failed. |
|
@JingsongLi thank you for the reminder, it took me a while to find the root cause... |
|
@JingsongLi @YannByron do you have to take a look ? thank you |
JingsongLi
reviewed
Aug 16, 2024
There was a problem hiding this comment.
Looks good to me! @ulysses-you
Just left one minor comment.
| extends PaimonBaseScan(table, requiredSchema, filters, reservedFilters, pushDownLimit) | ||
| with SupportsRuntimeFiltering | ||
| with SupportsReportPartitioning { | ||
|
|
||
| override def outputPartitioning(): Partitioning = { | ||
| def withDisabledBucketedScan(): PaimonScan = { |
There was a problem hiding this comment.
good naming! but it seems conflict with line40..
There was a problem hiding this comment.
bucketedScanDisabled and disableBucketedScan?
|
+1 Thanks @ulysses-you for the contribution. Merging... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This pr adds a new rule
DisableUnnecessaryPaimonBucketedScanto support auto disable bucketed scan if the bucket scan is not actually effective i.e., there is no shuffle exchange been removed. This change is to avoid performance regression since the bucketed scan may have smaller parallelism than normal scan.For example: a table with bucket key x but user join/group-by/partition-by on column y.
Note, this rule is inspired from Spark
DisableUnnecessaryBucketedScanbut work for v2 scan.Tests
Add test.
API and Format
no
Documentation