[common] supports configuring force-lookup. #3905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Comment in Issue. |
liming30
force-pushed
the
add_compact_strategy_configuration
branch
from
2b02d76 to
9338ec9
Compare
liming30
changed the title
JingsongLi
reviewed
Aug 7, 2024
| @@ -2024,6 +2032,10 @@ public boolean metadataIcebergCompatible() { | |||
| return options.get(METADATA_ICEBERG_COMPATIBLE); | |||
| } | |||
|
|
|||
| public boolean forLookup() { | |||
There was a problem hiding this comment.
Can you remove this method? It is hard to figure out difference from needLookup.
JingsongLi
reviewed
Aug 7, 2024
...ink/paimon-flink-common/src/main/java/org/apache/paimon/flink/sink/AsyncLookupSinkWrite.java
Show resolved
Hide resolved
|
+1 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: subtask of #3868
[common] supports configuring force-lookup
Tests
org.apache.paimon.table.PrimaryKeyFileStoreTableTest#testForceLookupCompactionAPI and Format
Documentation