Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[parquet] Child vector of complex type should arrange elements compactly (like orc) #3883

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

yuzelin
Copy link
Contributor

@yuzelin yuzelin commented Aug 2, 2024

Purpose

For orc, if we have 4 rows of ARRAY<ARRAY<STRING>: [[0, null], [1], [], null], [2], [], null]. The data layout is:

image

Currently, the parquet format layout is not same. For example, the inner IntVector will have more than one null value (that is ,the empty and null array will be set as null value in inner vector). This PR make parquet to be consistent with orc.

Tests

API and Format

Documentation

@yuzelin yuzelin changed the title [WIP][parquet] Child vector of complex type should arrange elements compactly (like Orc) [WIP][parquet] Child vector of complex type should arrange elements compactly (like orc) Aug 2, 2024
@yuzelin yuzelin force-pushed the refactor_parquet_nested branch 3 times, most recently from 8799497 to 4a44158 Compare August 5, 2024 15:15
@yuzelin yuzelin changed the title [WIP][parquet] Child vector of complex type should arrange elements compactly (like orc) [parquet] Child vector of complex type should arrange elements compactly (like orc) Aug 5, 2024
@yuzelin yuzelin force-pushed the refactor_parquet_nested branch from 4a44158 to 1fb1867 Compare August 6, 2024 07:22
@JingsongLi JingsongLi closed this Aug 8, 2024
@JingsongLi JingsongLi reopened this Aug 8, 2024
@Stephen0421
Copy link
Contributor

+1

1 similar comment
@JingsongLi
Copy link
Contributor

+1

@JingsongLi JingsongLi merged commit fd7ab43 into apache:master Aug 8, 2024
16 of 20 checks passed
@yuzelin yuzelin deleted the refactor_parquet_nested branch December 4, 2024 02:22
yuzelin pushed a commit to yuzelin/paimon that referenced this pull request Dec 20, 2024
JingsongLi pushed a commit that referenced this pull request Dec 21, 2024
Zouxxyy pushed a commit to Zouxxyy/incubator-paimon that referenced this pull request Jan 3, 2025
…olumn vectors like orc (apache#4745)

(cherry picked from commit b50040a)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants