[core] fix the collect of overlapped snapshots #3755
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @askwang , can you add test cases? |
askwang
changed the title
test added. |
askwang
force-pushed
the
fix-overlapped-snapshot
branch
from
e82b40e to
3848268
Compare
|
@JingsongLi can you help take a look, ths |
|
Hi @askwang Please try not to modify the code solely based on its naming. Instead, identify issues through practical application, as the naming of the code may simply be a previous naming error. This should include 'previous', which is the safe boundary for checking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When call
findOverlappedSnapshots(List<Snapshot> taggedSnapshots, long beginInclusive, long endExclusive).If beginInclusive is 10, endExclusive is 15, the range is [10, 15), and the taggedSnapshots is [8, 9, 11, 12, 15].
In previous way, the overlapped snapshots is [9, 11, 12]. Actually is only [11, 12].
Tests
API and Format
Documentation