[spark] Support StringEndsWith filter in SparkFilterConverter #3714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
reviewed
Jul 10, 2024
| BinaryString minStr = (BinaryString) min; | ||
| BinaryString maxStr = (BinaryString) max; | ||
| BinaryString pattern = (BinaryString) patternLiteral; | ||
| return (minStr.endsWith(pattern) || minStr.compareTo(pattern) <= 0) |
There was a problem hiding this comment.
Really works? Can you add more tests?
Endswith does not support range filtering very well.
There was a problem hiding this comment.
OK，had add tests to test it. @JingsongLi
There was a problem hiding this comment.
+1 with @JingsongLi, does endWith really have any effect on range filtering?
added 2 commits
July 10, 2024 15:23
JingsongLi
reviewed
Jul 10, 2024
Zouxxyy
reviewed
Jul 10, 2024
| @@ -192,6 +210,11 @@ public void testDate() { | |||
|
|
|||
| @Test | |||
| public void testIgnoreFailure() { | |||
| testStartsWith(); | |||
There was a problem hiding this comment.
No need modify this, this is only to test convertIgnoreFailure, regardless of the filter used
| BinaryString minStr = (BinaryString) min; | ||
| BinaryString maxStr = (BinaryString) max; | ||
| BinaryString pattern = (BinaryString) patternLiteral; | ||
| return (minStr.endsWith(pattern) || minStr.compareTo(pattern) <= 0) |
There was a problem hiding this comment.
+1 with @JingsongLi, does endWith really have any effect on range filtering?
|
By the way, since endwith has no range filtering capability, even we pass it to paimon, it has no filtering effect... |
|
can add test for partition filering |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #3715
Tests
API and Format
Documentation